no_std support for `fuel-tx` and `fuel-vm` #582

Dentosal · 2023-09-07T06:25:05Z

Makes fuel-vm crate compile without stdlib, but still requireing alloc. This is a breaking change, and the corresponding updates to fuel-core are done in FuelLabs/fuel-core#1367. Most of the breakage comes from removing std::io::Error, especially from storage traits which now use concrete error types instead and only allow std::io::Error on some variants available with std feature enabled.

Currently passes with the following command for RiscV:

cargo build --target riscv32imac-unknown-none-elf -p fuel-vm --no-default-features --features alloc

and check passes for freestanding x86-64, but building doesn't, since it requires soft-float configuration:

cargo check --target x86_64-unknown-none -p fuel-vm --no-default-features --features alloc

Closes #230 #536

…lloc

Co-authored-by: Green Baneling <[email protected]>

…rect len

Co-authored-by: Green Baneling <[email protected]>

fuel-crypto/src/secp256/backend/r1/p256.rs

fuel-merkle/src/binary/merkle_tree.rs

fuel-merkle/src/common/storage_map.rs

fuel-merkle/src/storage.rs

bvrooman · 2023-09-20T17:12:13Z

fuel-storage/src/error.rs

+}
+
+#[cfg(feature = "std")]
+impl From<StorageError> for std::io::Error {


Are there still instances where we use std::io::Error? Or can we get rid of this conversion now?

fuel-vm/src/arith.rs

Dentosal · 2023-09-20T23:57:49Z

Migrating to a single concrete StorageError type seems like an disliked approach, and while I still like it more myself, I can see that it has downsides.

I've reversed the direction on this, and instead parametrized InterpreterError with a generic parameter carrying the storage error type, so that we don't have to use a custom error trait. Now the resulting error type is directly available to the users of fuel-vm, and isn't hidden behind std::io::Error. This means minor changes on fuel-core side, but it shouldn't be too hard, especially since we only used type-erased errors before.

Let me know your opinions on the new approach.

fuel-vm/src/interpreter/blockchain.rs

xgreenx · 2023-09-21T11:35:34Z

fuel-vm/src/error.rs

+#[cfg(feature = "std")]
 use thiserror::Error;


I would prefer to remove usage of thiserror and replace it with similar Display implementation. Maybe we can use another macro(no_std compatible) to derive exact the same implementation of the Display trait.

fuel-vm/src/interpreter/contract.rs

bvrooman

LGTM. Personally, I like the approach to parameterize the InterpreterError because it allows us to maintain separation between discrete levels of logic.

re: thiserror - If we want to remove thiserror in favour of writing custom Display traits, I think that we can do that in a separate PR.

xgreenx

It would be nice to have it in this PR because it can remove some std features from some crates, but I'm also okay with doing that in a separate PR=)

bvrooman · 2023-09-22T02:11:28Z

.github/workflows/ci.yml

@@ -95,7 +97,7 @@ jobs:
      - uses: dtolnay/rust-toolchain@master
        with:
          toolchain: ${{ env.RUST_VERSION }}
-          targets: "thumbv6m-none-eabi,wasm32-unknown-unknown"
+          targets: "thumbv6m-none-eabi,riscv32imac-unknown-none-elf,wasm32-unknown-unknown"


Just curious - did you chose the IMAC extensions for any particular reason, or is that just a safe default?

That's closes to the internal target used by risc-zero

Dentosal · 2023-09-22T02:44:23Z

I'm leaving the thiserror -> display impl change for a follow-up PR, as I feel like it's nicer to review separately.

Addresses breaking fuel-vm changes from FuelLabs/fuel-vm#582, FuelLabs/fuel-vm#578, FuelLabs/fuel-vm#588 and FuelLabs/fuel-vm#587. Waiting for a new fuel-vm release. --------- Co-authored-by: Green Baneling <[email protected]>

Dentosal added 14 commits September 1, 2023 05:55

WIP

9df7764

WIP: use k256 crate for no_std compliant cryptography

b5c74f4

Merge branch 'master' into dento/nostd_crypto

2812411

Re-add secp256k1 crate support, add backend selection

6b7f326

Fix clippy issues with features on/off

4eda0ee

Merge branch 'master' into dento/nostd_crypto

f1c6df6

Fmt toml files

dcd67d9

Cleanup for CI

f9465cb

Add changelog entry

637368b

Doc-tests cleanup

b68c1c5

Rename secp module to secp256

1640c4e

Fix warnings with no_std target

73bd6c1

Run checks for no_std fuel-crypto

94ad309

WIP

24cad19

Dentosal added breaking A breaking api change no changelog Skips the CI changelog check labels Sep 7, 2023

Dentosal self-assigned this Sep 7, 2023

Merge branch 'master' into dento/nostd

14b19c3

Dentosal mentioned this pull request Sep 11, 2023

Error propagation #230

Closed

Dentosal added 9 commits September 13, 2023 08:43

WIP

4537fbd

WIP: before attempting to un-indirect error types

926643c

Error type rework

c0f193d

Change deps from last commit to be no_std

3838725

Make cargo check work under --target x86_64-unknown-none --features a…

2511ad9

…lloc

Toml fmt

3f69a40

Move more stuff out of #[cfg(feature = "std")]

a2ee758

Cleanup fuel-asm cfgs

3d255a9

Add changelog

b45cbdf

Dentosal added fuel-vm Related to the `fuel-vm` crate. and removed no changelog Skips the CI changelog check labels Sep 13, 2023

Dentosal and others added 5 commits September 20, 2023 17:59

Use alloc feature with tests

90d0050

Remove a useless import

be98b79

Use qualified path instead of an import

1001bec

Co-authored-by: Green Baneling <[email protected]>

bugfix: StorageRead<ContractsRawCode> of MemoryStorage returned incor…

d398c76

…rect len

Update fuel-asm/src/encoding_tests.rs

20b5b5c

Co-authored-by: Green Baneling <[email protected]>

Dentosal requested a review from xgreenx September 20, 2023 15:21

bvrooman reviewed Sep 20, 2023

View reviewed changes

Dentosal added 4 commits September 21, 2023 00:11

WIP: adding fully generic storage error (likely not)

3ec9c1c

more wip

412c55f

WIP: tests passing again

9ea67a8

Cleanup: clippy

a7f6382

Merge branch 'master' into dento/nostd

618a6bd

Dentosal requested a review from bvrooman September 21, 2023 00:30

Minor moments after review

4433b49

xgreenx reviewed Sep 21, 2023

View reviewed changes

Change two match'es to map_err's

94d1050

bvrooman approved these changes Sep 21, 2023

View reviewed changes

xgreenx approved these changes Sep 21, 2023

View reviewed changes

bvrooman reviewed Sep 22, 2023

View reviewed changes

Dentosal added this pull request to the merge queue Sep 22, 2023

Merged via the queue into master with commit 76eb3e0 Sep 22, 2023
36 checks passed

Dentosal deleted the dento/nostd branch September 22, 2023 02:49

Dentosal mentioned this pull request Sep 22, 2023

Replace thiserror with derive_more::Display #587

Merged

This was referenced Sep 27, 2023

Release 0.38.0 #590

Merged

Fix nostd issue with getrandom in Wasmer #316

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

no_std support for `fuel-tx` and `fuel-vm` #582

no_std support for `fuel-tx` and `fuel-vm` #582

Dentosal commented Sep 7, 2023 •

edited by xgreenx

Loading

bvrooman Sep 20, 2023

Dentosal commented Sep 20, 2023 •

edited

Loading

xgreenx Sep 21, 2023 •

edited

Loading

bvrooman left a comment

xgreenx left a comment

bvrooman Sep 22, 2023

Dentosal Sep 22, 2023

Dentosal commented Sep 22, 2023

no_std support for fuel-tx and fuel-vm #582

no_std support for fuel-tx and fuel-vm #582

Conversation

Dentosal commented Sep 7, 2023 • edited by xgreenx Loading

bvrooman Sep 20, 2023

Choose a reason for hiding this comment

Dentosal commented Sep 20, 2023 • edited Loading

xgreenx Sep 21, 2023 • edited Loading

Choose a reason for hiding this comment

bvrooman left a comment

Choose a reason for hiding this comment

xgreenx left a comment

Choose a reason for hiding this comment

bvrooman Sep 22, 2023

Choose a reason for hiding this comment

Dentosal Sep 22, 2023

Choose a reason for hiding this comment

Dentosal commented Sep 22, 2023

no_std support for `fuel-tx` and `fuel-vm` #582

no_std support for `fuel-tx` and `fuel-vm` #582

Dentosal commented Sep 7, 2023 •

edited by xgreenx

Loading

Dentosal commented Sep 20, 2023 •

edited

Loading

xgreenx Sep 21, 2023 •

edited

Loading